Typed Relation #3
Conversation
Person's auto_entitylabel config isn't working without the token module.
includes field, widget, and formatter
|
I'll give it a spin tomorrow! |
|
Oh, yeah. I should have checked the coding standards first... I'll clean those up now. |
|
I ran through the testing steps and can verify that this worked as expected. I did have trouble upgrading the module in-situ and having the new field appear. I ended up starting with a new vagrant from scratch. |
|
@patdunlavey yeah, I haven't figured out how to get modules that define content types using configs to uninstall cleanly. Glad there weren't any other problems. |
| */ | ||
| public function viewElements(FieldItemListInterface $items, $langcode) { | ||
| $elements = parent::viewElements($items, $langcode); | ||
| $values = $items->getValue(); |
There was a problem hiding this comment.
Variable never used, can be removed.
There was a problem hiding this comment.
Ah! Yes, that was hold over from a previous strategy.
| 'type' => 'text', | ||
| 'size' => 'tiny', | ||
| 'not null' => TRUE, | ||
| ]; |
There was a problem hiding this comment.
I don't understand what is going on here. Is this adding in the schema? Could/should this be a yaml file?
There was a problem hiding this comment.
According to the Drupal 8 "Create a custom field type" documentation: "FieldItemInterface::schema() should be overridden, in order to tell the system how to store the value(s) for the field." Every example of custom fields I've seen does it.
* merge upstream (#3) * drupal 9 support * coding styles
Adds a TypedRelation Field, Formatter, and Widget. Also adds a Linked Agent field to the Person content type.
Related to issue: Islandora/documentation/issues/889 and Islandora/documentation/issues/893
Testing:
Interested parties: @patdunlavey @rosiel @rtilla1