Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 137 - Allow formatter to set url_only and url_plain. #138

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Feb 7, 2025

GitHub Issue: #137

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Puts the "URL only" and "Show URL as plain text" checkboxes on the field formatter settings page for authority links

What's new?

  • The parent, LinkFormatter, "locked down" those fields from inheriting classes by setting their access to true only if you're in a Link Formatter. This PR does the same, setting their access to true if you're in an Authority Link formatter.
  • Does this change require documentation to be updated? No
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

A description of what steps someone could take to:

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu self-requested a review February 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant