Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RDF configs to optional. #120

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 21, 2024

GitHub Issue: #119

Other Relevant

  • General discussion of Recipes

What does this Pull Request do?

Makes it possible to install Defaults without RDF.

What's new?

  • RDF removed from Defaults' requirements in info.yml

  • RDF-related configs moved to optional folder

  • RDF added as a suggest in composer.json.

  • Does this change require documentation to be updated? No

  • Does this change add any new dependencies? NO :)

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No

  • Could this change impact execution of existing code? No

How should this be tested?

  • Launch a fresh drupal, e.g with DDEV.
  • composer require drupal/controlled_access_terms
  • drush en controlled_access_terms_defaults (fails, RDF is required)
  • With this PR, it should install without RDF.
  • Also, if you had RDF installed already, it should install the RDF configs.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-asu seth-shaw-asu merged commit 3938f2a into Islandora:2.x May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants