Update CONTRIBUTING.md and Travis #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #76 +/- ##
=====================================
Coverage 100% 100%
Complexity 20 20
=====================================
Files 1 1
Lines 98 98
=====================================
Hits 98 98Continue to review full report at Codecov.
|
dannylamb
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1173 and Islandora/documentation#1175
What does this Pull Request do?
Adds the 'standard' version of CONTRIBUTING.md and add dev branch in travis
How should this be tested?
Look at the .md files and make sure they're good. CONTRIBUTING.md should match this.
Check travis to make sure I've updated correctly, because it's just copied from #75 (comment)
Additional notes
Not sure this one should be 'normalized,' since the differences look like they're more significant for chullo than for most of our contributing guides. Is the info in the 'old' one still relevant (side from updating some terms and version numbers)? Relevant enough to maintain a different versoning of the contributing file? Happy to revert if others feel this should be left alone.
Interested parties
@Islandora-CLAW/committers