Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servlet filter revert #13

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Islandora/documentation#966

What does this Pull Request do?

Reverts the previous commit, and bumps the version number for when we slice a new one. We're going back to working with a Tomcat valve for the time being, so we can move forward with Fedora 5.

Additional Notes:

We'll need to slice a new version of syn. Use ./gradlew shadowJar to build the fat -all jar and attach that to the release in addition to the thin jar you'd get from ./gradlew build.

Interested parties

@Islandora-CLAW/committers, @whikloj

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #13 into master will decrease coverage by 3.35%.
The diff coverage is 86.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
- Coverage     89.47%   86.11%   -3.36%     
- Complexity      112      116       +4     
============================================
  Files             9        6       -3     
  Lines           323      353      +30     
  Branches         53       65      +12     
============================================
+ Hits            289      304      +15     
- Misses           12       24      +12     
- Partials         22       25       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/ca/islandora/syn/settings/Site.java 100% <ø> (ø) 15 <0> (ø) ⬇️
...rc/main/java/ca/islandora/syn/settings/Config.java 100% <100%> (ø) 7 <4> (ø) ⬇️
src/main/java/ca/islandora/syn/settings/Token.java 93.75% <100%> (ø) 7 <2> (ø) ⬇️
src/main/java/ca/islandora/syn/token/Verifier.java 68.75% <50%> (-31.25%) 9 <5> (-1)
...java/ca/islandora/syn/settings/SettingsParser.java 81.93% <87.09%> (+1.93%) 50 <24> (+7) ⬆️
src/main/java/ca/islandora/syn/valve/SynValve.java 90.74% <90.74%> (ø) 28 <28> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9482e95...e5f235e. Read the comment docs.

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to revert

@whikloj whikloj merged commit c3fd5ac into Islandora:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants