Adding -loglevel error for large files

[dannylamb]

GitHub Issue: Part of the fix for Islandora/documentation#1278

What does this Pull Request do?

Adds -loglevel error to every ffmpeg command so that large files can be processed.

How should this be tested?

See Islandora/documentation#1278

Interested parties

@Islandora/8-x-committers @kayakr @antbrown

[codecov]

Codecov Report

Merging #82 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev      #82      +/-   ##
============================================
+ Coverage     94.77%   94.85%   +0.08%     
  Complexity      168      168              
============================================
  Files             9        9              
  Lines           689      700      +11     
============================================
+ Hits            653      664      +11     
  Misses           36       36

Impacted Files	Coverage Δ	Complexity Δ
Homarus/src/Controller/HomarusController.php	100% <100%> (ø)	13 <0> (+1)	⬆️
Gemini/src/UrlMinter/UrlMinter.php	100% <0%> (ø)	2% <0%> (-1%)	⬇️
Milliner/src/Service/MillinerService.php	99.2% <0%> (ø)	54% <0%> (ø)	⬇️
Gemini/src/Controller/GeminiController.php	98.24% <0%> (+0.03%)	19% <0%> (ø)	⬇️
Milliner/src/Controller/MillinerController.php	94.93% <0%> (+0.27%)	19% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ccf1e4...2b71096. Read the comment docs.

[antbrown]

I've tested this on a handful of environments and can concur a quiet ffmpeg is a happy ffmpeg (esp. for processing large files where stdout can get clogged up by ffmpeg giving a running commentary of what's going on)

[whikloj]

I'm not against this change, just wondering if we will ever want a more verbose logging?

Also what happens if I provide -loglevel info in the context reaction, such that my args end up as -loglevel info -loglevel error?

Should we do a more complex check for existing -loglevel arguments and (perhaps) add a warning to the homarus log if more verbose than error? Or document that logging is locked to the error state.

I'll try and pull this down and test some of these possibly problematic issues I'm noting here.

[dannylamb]

@whikloj Wasn't thinking about that 🤦‍♂️ Since any client could pass along an X-Islandora-Args header, I should sanitize here to catch all cases. After that we'll need to run a custom validator to throw things back at you if you try to set the loglevel in the action's form.

[dannylamb]

@whikloj eh how about we just reject any message that tries to set log level? that's honestly the cleanest way to handle it. i'll update the action to reject form submissions that try to set loglevel in the arguments field.

[whikloj]

👍