Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port work of @jordandukart in PR #144 #165

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Sep 16, 2022

GitHub Issue: n/a

What does this Pull Request do?

Repeats the work @jordandukart did in #144 for all the microservices now that they all use symfony/flex

What's new?

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

This really should have no descernible impact, other than when composer installing it you will not get a prompt to allow symfony/flex to execute code.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 76.56% // Head: 76.56% // No change to project coverage 👍

Coverage data is based on head (fe6a8be) compared to base (82320e5).
Patch has no changes to coverable lines.

❗ Current head fe6a8be differs from pull request most recent head e0719c0. Consider uploading reports for the commit e0719c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x     #165   +/-   ##
=========================================
  Coverage     76.56%   76.56%           
  Complexity      155      155           
=========================================
  Files             6        6           
  Lines           576      576           
=========================================
  Hits            441      441           
  Misses          135      135           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@whikloj
Copy link
Member Author

whikloj commented Sep 16, 2022

Actually, hold on with this. I realize I should just grab the original commit and edit as necessary.

* Update symfony/flex.

* Actually update the require.
@whikloj
Copy link
Member Author

whikloj commented Sep 16, 2022

That's better

@seth-shaw-asu seth-shaw-asu merged commit c6878a3 into Islandora:3.x Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants