Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to support Composerr 2 #107

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Oct 30, 2020

GitHub Issue: (link)

Composer issue when running "vagrant up" #1663

What does this Pull Request do?

Update minor version numbers of required packages in composer to versions that support Composer 2.

The Vagrant build is currently breaking due to composer incompatibility.

What's new?

Updates to:

Gemini:

  • doctrine/migrations version 1.5 to 1.8

Houdini:

  • symfony/flex from 1.1 to 1.9

No changes in behaviour of Islandora.

How should this be tested?

Along with update to islandora-playbook PR here do a build of the playbook and test Gemini and Houdini are working as expected by creating a repository image object with an image media and

  1. Verifying that the Fedora URL appears, and
  2. Observing the creation of image thumbnail media.

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Interested parties

@dannylamb

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #107 into dev will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #107      +/-   ##
============================================
+ Coverage     91.29%   91.89%   +0.59%     
  Complexity      175      175              
============================================
  Files             9        9              
  Lines           678      728      +50     
============================================
+ Hits            619      669      +50     
  Misses           59       59              
Impacted Files Coverage Δ Complexity Δ
Milliner/src/Controller/MillinerController.php 97.02% <0.00%> (+0.36%) 24.00% <0.00%> (ø%)
Milliner/src/Service/MillinerService.php 89.84% <0.00%> (+1.45%) 56.00% <0.00%> (ø%)
Recast/src/Controller/RecastController.php 74.33% <0.00%> (+1.69%) 36.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feda38d...176db36. Read the comment docs.

@dannylamb
Copy link
Contributor

LGTM. I'm currently facing Travis issues due to composer 2 and this appears to fix them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants