No gemini #45
Merged
No gemini #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #45 +/- ##
============================================
- Coverage 92.54% 89.08% -3.47%
+ Complexity 129 114 -15
============================================
Files 9 9
Lines 416 348 -68
============================================
- Hits 385 310 -75
- Misses 31 38 +7
Continue to review full report at Codecov.
|
elizoller
approved these changes
Mar 12, 2021
whikloj
pushed a commit
that referenced
this pull request
Oct 29, 2021
* Update IslandoraServiceProvider.php * Just using EntityMapper instead of Gemini * Updates from testing * Coding standards and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Goes with Islandora-Devops/isle-dc#132
What does this Pull Request do?
Delete the Gemini client, and replaces it with logic previously in POST requests for Gemini.
How should this be tested?
Test with Islandora-Devops/isle-dc#132
Interested parties
@Islandora/8-x-committers