Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GeminiClient to Crayfish Commons #16

Merged
merged 5 commits into from
Jan 9, 2019

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Mar 14, 2018

GitHub Issue: Islandora/documentation/issues/800

Required for: Islandora/Crayfish#44

What does this Pull Request do?

Moves the GeminiClient from Milliner to CrayfishCommons and adds a findByUrl function.

What's New

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Internal tests and testing of associated PR: Islandora/Crayfish#44

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #16 into master will increase coverage by 1.28%.
The diff coverage is 98.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     91.04%   92.32%   +1.28%     
- Complexity      111      126      +15     
============================================
  Files             8        9       +1     
  Lines           335      404      +69     
============================================
+ Hits            305      373      +68     
- Misses           30       31       +1
Impacted Files Coverage Δ Complexity Δ
src/Client/GeminiClient.php 98.55% <98.55%> (ø) 15 <15> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a317de...df766e2. Read the comment docs.

@dannylamb
Copy link
Contributor

Turns out I need this for getting exposing the Fedora URL as a link header on GET/HEAD requests, so Imma gonna merge this in now since it won't hurt anything.

@dannylamb dannylamb merged commit 6431c8f into Islandora:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants