Add lint and basic test #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecorall
force-pushed
the
fix-secret-generation
branch
4 times, most recently
from
cbf853e to
77bb13e
Compare
joecorall
force-pushed
the
fix-secret-generation
branch
from
77bb13e to
bcf2be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting some CI/CD integration tests going with this repo as a dependency. When running
./generate-secrets.shwas seeing some grep errorsBut that stderr message ended up just being an error that was printed but the command succeeded successfully, so the scripts in this repo are working well 👍
All that said, in doing all this debugging did add some GitHub Actions CI for lint/test we may want to consider in this repo?