Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make starter and add nightly build check #384

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Apr 17, 2024

Resolves #380 #357
Also tested make starter_dev on this PR and it successfully builds so think this also resolves #354

Before

make clean
make starter

Fails with

s6-envdir: fatal: unable to envdir /run/s6/container_environment: No such file or directory

After

make clean
make starter

Successfully builds

Tests

Also added a test on pushes to this repo to ensure make starter build production work. Added a nightly build to also perform the check and send failure notifications to #bots in Islandora Slack

@joecorall joecorall changed the title Wait for drupal container before trying to change its file permissions Fix make starter and add nightly build checked Apr 18, 2024
@joecorall joecorall marked this pull request as ready for review April 18, 2024 14:08
@joecorall joecorall changed the title Fix make starter and add nightly build checked Fix make starter and add nightly build check Apr 18, 2024
@aOelschlager
Copy link
Contributor

aOelschlager commented Apr 18, 2024

@joecorall Thank you for doing this! Edit note: I removed my original question here that was asking about an error with generate secrets on Windows because it was unrelated to the Windows test issue. I removed this for clarity in case anyone reads this in the future while trying to troubleshoot.

@aOelschlager aOelschlager self-requested a review April 19, 2024 00:15
Copy link
Contributor

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is all solid, and make starter works again,

@aOelschlager aOelschlager merged commit 3f03d68 into development Apr 19, 2024
1 check passed
@aOelschlager aOelschlager deleted the ISSUE-380 branch April 19, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such file or directory errors on make starter Make starter_dev fails to build
3 participants