Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Traefik to Latest Release #252

Merged

Conversation

misilot
Copy link
Contributor

@misilot misilot commented Apr 21, 2022

Provides some new features for ACME and a bunch of other fixes and features

I tested this by updating my docker-compose.traefik.yml file and doing a make up and the services all appeared to be there and running.

I am looking to increase some of the ACME settings and need at least v2.6.0

Thanks!

Related Tickets

#253
#252
Islandora/documentation#2096

@ysuarez
Copy link
Contributor

ysuarez commented May 18, 2022

@misilot I have been researching how to use zerossl, an it turns out they disallow using the free EC2 domains AWS gives you...

https://help.zerossl.com/hc/en-us/articles/360060863094-Forbidden-domain-names

I need to see if I can reuse any unused domains I may own, and have and point it to an AWS instance. Then I think I can create a free zerossl 90 day SSL cert. Though I will need more time to test this. I wonder if I can use a DigitalOcean instance with zerossl, not sure if DigitalOcean offers a "free domain" for their instances. @DonRichards I know you have used DigitalOcean for ISLE2 tests before, do you think that I should try using DigitalOcean for testing this PR? I have not used them yet, but I can try them out.

@misilot
Copy link
Contributor Author

misilot commented May 18, 2022

Ah, sorry didn't realize that! Sorry about that @ysuarez.

If you have access to a domain you could just create a random subdomain like islandora.domainname.com and point it towards your EC2 instance. It doesn't need to be the apex domain.

@ysuarez
Copy link
Contributor

ysuarez commented May 18, 2022

I started looking at adding a third-level domain on a personal domain that I already own, but my hosting company did not let me. I will ping you later on Slack to brainstorm on ideas on how to test this. For example, I was wondering if I need to use an AWS Elastic IP address for a test EC2 instance. Since I think at some point I have to update a name server to point the third-level domain to the EC2 instance, but I may not want to keep the EC2 instance running long enough or the DNS changes to propagate, hence I may target an Elastic IP. Though I could be completely mistaken.

@misilot
Copy link
Contributor Author

misilot commented May 18, 2022 via email

@DonRichards
Copy link
Member

@misilot Are we needing to test subdomains before we merge this? The scope of this looks like it's only upgrading traefik from 2.2.1 to 2.6.6, is that correct?

@misilot
Copy link
Contributor Author

misilot commented May 25, 2022

@DonRichards, if islandora.traefik.me works, I think it should be good.

I would also update to 2.7.0, since that was released recently.

But yes, the scope of this was only upgraded Traefik.

@misilot
Copy link
Contributor Author

misilot commented May 25, 2022

@DonRichards what are your thoughts on just targeting v2.7 instead of a specific point release?

Provides some new features for ACME and a bunch of other fixes and
features
@misilot
Copy link
Contributor Author

misilot commented May 26, 2022

@DonRichards I just figured out your question. I believe @ysuarez's question may belong to #253

Copy link
Member

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had to update docker-compose.yml as well for the change to take, but I was able to view the site and generate derivatives, so everything looks good to me. 👍

@seth-shaw-unlv seth-shaw-unlv merged commit 23d37e7 into Islandora-Devops:development Jun 2, 2022
@misilot
Copy link
Contributor Author

misilot commented Jun 2, 2022

Sorry about that @seth-shaw-unlv. Missed the make -B docker-compose.yml step.

Thanks for merging!

@misilot misilot deleted the traefik-update branch June 2, 2022 15:43
misilot added a commit to misilot/isle-dc that referenced this pull request Jun 6, 2022
Provides some new features for ACME and a bunch of other fixes and features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants