Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 support #289

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Drupal 10 support #289

merged 2 commits into from
Sep 21, 2023

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Sep 20, 2023

Summary

This PR addresses a couple Drupal 10 issues.

Fix drush 12 flag

Drush 12 removed the deprecated --pipe flag in drush-ops/drush#5502

Drush 12 is required for Drupal 10.

This PR replaces the pipe flag with --format=string

reverse_proxy_trusted_headers

Also pull in changes from Islandora-Devops/isle-site-template#7 so isle-dc gets the correct reverse_proxy_trusted_headers settings

@joecorall joecorall changed the title Replace drush --pipe flag with --format=string Drupal 10 support Sep 20, 2023
@aOelschlager
Copy link
Contributor

I tested this on my local machine and I was able to get isle-dc to work without receiving the pipe and undefined constant errors.

@joecorall
Copy link
Contributor Author

:shipit: 🚢

Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nigelgbanks nigelgbanks merged commit da26838 into Islandora-Devops:main Sep 21, 2023
@joecorall joecorall deleted the patch-1 branch September 22, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants