Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EDTF Year processor settings #143

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix EDTF Year processor settings #143

merged 2 commits into from
Apr 26, 2024

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Apr 13, 2024

Controlled_access_terms: the solr processor settings are of a new format

Without the settings changes to the new format, this will cause the processor to break and/or emit errors

Related Links

Islandora/controlled_access_terms#113
Islandora/controlled_access_terms#114
https://islandora.slack.com/archives/CM5PPAV28/p1712939510602939
Islandora/controlled_access_terms#117

@aOelschlager aOelschlager self-requested a review April 17, 2024 17:26
@aOelschlager
Copy link
Contributor

aOelschlager commented Apr 25, 2024

Yesterday, I pulled this in to test and I'm still getting search_api processor errors.
I tested this on a new isle-dc clone using this branch of the starter site. I used workbench to load demo content from the islandora demo objects repo.
Screenshot from 2024-04-24 12-03-28
Screenshot from 2024-04-24 12-05-11
When I do a search this shows up in the logs.
Screenshot from 2024-04-25 09-37-31
I'm going to update controlled access terms on my test site so I can utilize the recent pr and see if that takes care of these messages in the log.

@aOelschlager
Copy link
Contributor

Updating controlled access terms seemed to fix that. I'm going test this one more time with the updated controlled access terms on a new starter site just to make sure but I think it should be good to go.

@aOelschlager
Copy link
Contributor

There were no EDTF errors or messages in the logs with this pr and the most recent controlled access terms release. Could the lock file be updated to use that release or does that need to be submitted as a separate pr?

@joecorall
Copy link
Contributor Author

Thanks @aOelschlager - updated controlled_access_terms

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks Joe!

@aOelschlager aOelschlager merged commit 3773716 into main Apr 26, 2024
4 checks passed
@aOelschlager aOelschlager deleted the solr-edtf-settings branch April 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants