Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claw 948 #80

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Claw 948 #80

merged 2 commits into from
Oct 23, 2018

Conversation

ppound
Copy link
Contributor

@ppound ppound commented Oct 11, 2018

create simpletest directories, chown feature modules so they are owned by www-data and add ubuntu or vagrant user to appropriate group

@ppound ppound mentioned this pull request Oct 11, 2018
Closed
@dannylamb
Copy link
Member

vagrant up

dannylamb
dannylamb approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works as intended. Tested on Ubuntu. Tests could be run with sudo -u www-data php core/scripts/run-tests.sh --suppress-deprecations --url http://127.0.0.1:8000 --verbose --php which php --module "islandora". Features exported cleanly.

:shipit:

@dannylamb dannylamb merged commit 39ffe55 into Islandora-Devops:master Oct 23, 2018
@rosiel rosiel deleted the CLAW-948 branch May 3, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppound @dannylamb