Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveMQ service improvements #32

Merged
merged 2 commits into from
Nov 21, 2017

Conversation

fkleon
Copy link
Contributor

@fkleon fkleon commented Nov 19, 2017

GitHub Issue: n/a

What does this Pull Request do?

Removes the need for an ubuntu user that is currently required to run ActiveMQ.

Similar background as raised for the old dev environment: islandora-deprecated/claw_vagrant#57

This PR adds a dedicated activemq system user.

What's new?

  • Added the activemq system user.
  • Added a systemd unit to manage the activemq service, which now runs as the activemq system user.
  • Added a transitional task that removes the old init.d symlink

How should this be tested?

  • Reprovision ActiceMQ to an existing environments with:
    ansible-playbook -i ./inventory/vagrant/hosts playbook.yml --tags activemq
  • Cycle activemq: sudo systemctl restart activemq
  • Access the ActiceMQ web UI and make sure it loads correctly: http://localhost:8161/admin/

Interested parties

@Islandora-CLAW/committers

* Add activemq service user
* Use systemd unit to manage activemq
@jonathangreen
Copy link
Contributor

Hi @fkleon. These changes look awesome, much nicer way to deploy ActiveMQ. I will try to give this a test run tomorrow so we can get it merged.

@jonathangreen jonathangreen self-assigned this Nov 20, 2017
@fkleon
Copy link
Contributor Author

fkleon commented Nov 20, 2017

@jonathangreen Thanks!
I've just noticed that some of these internal ansible roles also have their own repositories, e.g. Islandora-Devops/ansible-role-activemq. I guess you're planning to migrate to those soon?
Which ones are the canonical source for now and should be used for pull requests?

@jonathangreen
Copy link
Contributor

Good call @fkleon, @whikloj is working on breaking out the internal roles and putting them in galaxy in Islandora/documentation#743. I'm thinking we merge this here, and make a note for @whikloj to do a final sync before he does the switchover. @whikloj thoughts?

@jonathangreen
Copy link
Contributor

Tested and looks good to me.

@jonathangreen jonathangreen merged commit dc7ad97 into Islandora-Devops:master Nov 21, 2017
@jonathangreen
Copy link
Contributor

Thanks for the contribution @fkleon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants