Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grok. #229

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Remove Grok. #229

merged 1 commit into from
Sep 22, 2022

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Sep 20, 2022

GitHub Issue: #2166 [CODE TASK] Playbook takes a very long time.

What does this Pull Request do?

Removes Grok from the playbook since it is no longer needed.

What's new?

For a while now the playbook has been installing OpenJpeg from the Ubuntu repository. That makes this task redundant since it was disguising its executable as opj_decompress anyway.

  • Does this change require documentation to be updated? No
  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

Build a playbook on this branch and ensure that JP2 files are handled as expected.

Specifically:

Add test objects:

  1. Enable the Islandora Mirador module.
  2. Create a Paged Content object with display hint 'Mirador'
  3. Add a child object with model Page.
  4. Add a File media to that object and upload a JP2 file. Check the "Original File" role.

Configure Mirador

  1. Go to Admin -> Index and click on "Context" under the Context UI category
  2. Edit the "Paged Content - Mirador" context.
  3. There should already be a Block reaction but there are no blocks placed yet. Click "Place Block"
  4. Choose the Mirador block, place it in Content.
  5. In the Manifest URL text field, put https://localhost:8000/node/[node:nid]/book-manifest-original
  6. Save the block, then click "Save and Continue"

Verify JP2 behaviour

  1. Go to the child object and click on the Media tab.
  2. You should see Thumbnail and Service File media generated from the original JP2 File media
  3. Go to the parent object. You should see a Mirador interface, and you can verify by right-clicking or via Web Inspector that it is making requests to Cantaloupe for slices of a JP2 image.

Additional Notes:

This saves about 5 minutes from the playbook build process, and removes a long-standing dependency on software that we were not updating.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers @rosiel

@whikloj whikloj self-requested a review September 21, 2022 17:43
Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@whikloj whikloj merged commit 8269817 into dev Sep 22, 2022
@whikloj whikloj deleted the issue-2166-remove-grok branch September 22, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants