Implement recast service #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whikloj Just a guess from Travis's output, but maybe try generating a composer.json using PHP 5.6? #42 (comment) |
|
@dannylamb This should "work" now, but the Gemini and Recast tests will fail as they rely on the Crayfish-Commons PR. So once that is merged, then these tests could be restarted. |
|
Ran the script and getting an exception thrown. The service is not being registered. |
|
@whikloj can you hit the button on this one? i'd like to test this out. |
|
i am resisting the urge to hit it myself and am trying not to implicate myself in the pull 😁 |
|
@dannylamb so in the Crayfish Couple changes to match up with the changes in Crayfish but this still works, though for those things not in Gemini I can't do anything so we might want to consider whether more things should be mapped using it. |
|
well this has become completely screwed. I'll see if I can get all the pieces together again, but don't bother trying this one. |
Move Milliner to use GeminiClient in Crayfish-Commons
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 100% 97.1% -2.9%
- Complexity 122 140 +18
==========================================
Files 9 9
Lines 570 621 +51
==========================================
+ Hits 570 603 +33
- Misses 0 18 +18
Continue to review full report at Codecov.
|
|
@dannylamb Codecov is kicking me for boosting it to 100% previously 🤦♂️ but otherwise this is good. I updated the testing instructions above. |
|
You flew too close to the 🌞 @whikloj I can give this a whirl then 👍 |
|
@whikloj Both add and replace work out just fine. JSONLD looks good: But turtle is re-writing namespaces to ns01, ns02, etc... Since it's the default return format, it'd be nice to sort that out. EasyRDF is always a pain in the arse, but I'm guessing you could stash the namespaces from what you receive and re-use them when serializing out. If that turns out to be an ordeal we can spool off another ticket, because what you have works just fine with jsonld. |
|
@dannylamb could we put this in and then I'll work on the serialization issue after. Just to get this in and available. |
dannylamb
approved these changes
Feb 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation/issues/800
Depends on: Islandora/Crayfish-Commons#16
What does this Pull Request do?
This PR implements a new API-X extension service inside of Crayfish. The service binds to resources of rdf:type ldp:RdfSource and rewrites the request to add Fedora URIs for Drupal URIs it finds in the Gemini DB.
What's new?
/by_uriendpoint with a getByUri function which uses the above search.svc:recasturi via API-XHow should this be tested?
As API-X with Fedora 5 is still broken these are new testing instructions.
Pull down a claw-playbook (or delete the contents of your
roles/externaldirectory on an existing one) and edit the requirements.yml to make the following change:Then
vagrant upOnce done you should have a completely functioning Claw instance.
Create a new repository object as a collection, then create a new repository object (as whatever) and make it part of the first collection.
Find this second object's Fedora URL. I normally just dig through all the URIs in Fedora but you can also look in the Gemini DB if you want.
Once you have your Fedora URI
Then using that URI as your
Apix-Ldp-Resourcecall the Recast service and note the change in thememberOfpredicate values.http://localhost:8000/recast/calls the default action ofaddand is the same as callinghttp://localhost:8000/recast/add. Tryhttp://localhost:8000/recast/replaceto remove the corresponding Drupal urisAdditional Notes:
Interested parties
@Islandora-CLAW/committers