mod: Beginner Guide: rewrote the gamma correction section #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbritain
reviewed
Jan 11, 2025
| - `gbuffers_water` - all translucent terrain | ||
| - `gbuffers_textured` - particles | ||
| - `gbuffers_entities` - entities | ||
| A "shader" is, by definition, any program that is executed on the GPU. For Minecraft, these shader programs (also know as passes) can be sorted into two distinct categories: composite passes, which execute for the entire screen, and gbuffers passes, which execute only for specific geometry. Each individual program is composed of several shader stages, two of which are required: a vertex shader, which executes once for each vertex of the geometry, and a fragment shader, which executes once for every pixel that covers the geometry. You can optionally include a compute, geometry, and/or tesselation stage for each pass. |
There was a problem hiding this comment.
I wouldn't call them composite passes, rather fullscreen passes, and probably put both that and gbuffers in quotes
There was a problem hiding this comment.
My language here was taken directly from the Iris Docs. Notably, there, they're called "composite-style" and "gbuffers-style" passes. I agree with both of your points, though.
| @@ -1,16 +1,16 @@ | |||
| --- | |||
| title: Simple Post Effects | |||
| title: Your First Effect | |||
There was a problem hiding this comment.
Suggested change
| title: Your First Effect | |
| title: Your First Post Processing Effect |
There was a problem hiding this comment.
I didn't do this because of
That's on a 14-in laptop in full screen, which I think is how a decent amount of people will view the tutorial. "Your First Shader Effect" could be a good alternative, or you could just accept this
src/content/docs/current/Guides/Your First Shader/1_composite.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/current/Guides/Your First Shader/1_composite.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/current/Guides/Your First Shader/1_composite.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/current/Guides/Your First Shader/1_composite.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/current/Guides/Your First Shader/1_composite.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
Co-authored-by: Josh Britain <50422789+jbritain@users.noreply.github.com>
jbritain
reviewed
Jan 11, 2025
| ``` | ||
| ::: | ||
|
|
||
| By default, `colortex` buffers are RGBA8, meaning they store 8-bit integers which can encode a maximum of 256 color values. By increasing the precision to 16-bit, our buffer can now encode 65535 color values! |
There was a problem hiding this comment.
It can encode 256 per channel, that's still 16777216 actual colours - I would specify that it's per channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Gamma Correction section to be more in-depth and give a better explanation of color spaces.