Added config options for Team Leveling #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added ``giveLevelRewards`` to determine if level rewards are given out for leveling up. - added ``isLevelExponential`` to determine whether the plugin uses an exponential function when determining the level of the team. - added ``flatExpRequirement`` to change how much experience is required per level. - added ``curvedExpModifier`` to determine how much experience is required per level using the exponential function. - made ``getLeve()`` abstract so that the plugin can use the configuration to determine the level.
sh0inx
added a commit
to Iridium-Development/IridiumSkyblock
that referenced
this pull request
Mar 1, 2024
- the other side of [IridiumTeams #49](Iridium-Development/IridiumTeams#49)
- added ``level`` command, to allow players to check their current team level and to see how much experience they need to level up - removed ``level`` as an alias from ``info`` command - removed ``isLevelExponential``, as setting ``curvedModifier`` to 0 will turn it into a linear function. - added ``levelInfo`` for ``level`` command - added ``minLevel`` to ``MissionData`` and ``ShopItem`` classes, and functionality to check if the team interacting with these features is the right level to use them. - replaced constants with variables from the config to allow customization of the level formula (and engineered a formula to get the experience for a level, you're welcome nerds) - updated tests
Closed
sh0inx
added a commit
to Iridium-Development/IridiumSkyblock
that referenced
this pull request
May 10, 2024
commit ec3d514 Merge: 28800ec 898bc8a Author: Shyanne <randomgirlisweird@gmail.com> Date: Sat Mar 16 10:17:24 2024 -0400 Merge branch 'master' into level-configuration commit 28800ec Author: Shyanne <randomgirlisweird@gmail.com> Date: Sun Mar 3 13:26:48 2024 -0500 Fixed bank placeholders and GUIs commit c6348a5 Author: Shyanne <randomgirlisweird@gmail.com> Date: Sun Mar 3 01:46:14 2024 -0500 small fixes commit faaf0c9 Author: Shyanne <randomgirlisweird@gmail.com> Date: Sun Mar 3 00:55:32 2024 -0500 Added More Level Features - added ``minLevel`` to ``BiomeItem`` and ``SchematicConfig`` classes, and functionality to use them - added ``islandCreationCost`` in config to check if we want islands to cost something on creation or just regen - updated configs to reflect changes in teams (also updated default regenCost to be 0 because... y'know) - removed formulas from ``getLevel()`` because we pull from islandManager instead - added ``island_experienceToLevelUp`` and ``island_experienceForNextLevel`` placeholders, which return the amount of experience left needed to level up and the experience needed for the next level respectively commit 1c3f686 Author: Shyanne <randomgirlisweird@gmail.com> Date: Fri Mar 1 13:07:12 2024 -0500 added leveling toggle commit ade8705 Author: Shyanne <randomgirlisweird@gmail.com> Date: Fri Mar 1 13:02:00 2024 -0500 no negative values here commit c3cc083 Author: Shyanne <randomgirlisweird@gmail.com> Date: Fri Mar 1 12:56:12 2024 -0500 Added Island Level Configuration - the other side of [IridiumTeams #49](Iridium-Development/IridiumTeams#49)
PeachesMLG
reviewed
May 10, 2024
src/main/java/com/iridium/iridiumteams/commands/LevelCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumteams/listeners/TeamLevelUpListener.java
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumteams/managers/ShopManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Peaches_MLG <PeachesMLG100@gmail.com>
PeachesMLG
reviewed
Jun 10, 2024
src/main/java/com/iridium/iridiumteams/commands/LevelCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumteams/gui/ShopCategoryGUI.java
Outdated
Show resolved
Hide resolved
PeachesMLG
approved these changes
Jun 10, 2024
PeachesMLG
added a commit
to Iridium-Development/IridiumSkyblock
that referenced
this pull request
Jun 10, 2024
* Added Island Level Configuration - the other side of [IridiumTeams #49](Iridium-Development/IridiumTeams#49) * no negative values here * added leveling toggle * Added More Level Features - added ``minLevel`` to ``BiomeItem`` and ``SchematicConfig`` classes, and functionality to use them - added ``islandCreationCost`` in config to check if we want islands to cost something on creation or just regen - updated configs to reflect changes in teams (also updated default regenCost to be 0 because... y'know) - removed formulas from ``getLevel()`` because we pull from islandManager instead - added ``island_experienceToLevelUp`` and ``island_experienceForNextLevel`` placeholders, which return the amount of experience left needed to level up and the experience needed for the next level respectively * small fixes * Fixed bank placeholders and GUIs * switch to > instead of != for level min Co-authored-by: Peaches_MLG <PeachesMLG100@gmail.com> * Changes --------- Co-authored-by: Peaches_MLG <PeachesMLG100@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
giveLevelRewardsto determine if level rewards are given out for leveling up.isLevelExponentialto determine whether the plugin uses an exponential function when determining the level of the team.flatExpRequirementto change how much experience is required per level.curvedExpModifierto determine how much experience is required per level using the exponential function.getLevel()abstract so that the plugin can use the configuration to determine the level.