Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorter file names for Windows #6212

Closed
wants to merge 1 commit into from
Closed

Shorter file names for Windows #6212

wants to merge 1 commit into from

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Jun 14, 2024 •
edited
Loading

In this PR I have renamed some golden files for their paths to become shorter so that Windows build doesn't fail.
The original problem happened in the cardano-api:

Cloning into 'D:\a\cardano-api\cardano-api\dist-newstyle\src\plutus-e0298550df4155ce'...
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-invalid-key/verifyEcdsaSecp256k1Signature-invalid-key.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-invalid-key/verifyEcdsaSecp256k1Signature-invalid-key.uplc.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-long-key/verifyEcdsaSecp256k1Signature-long-key.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-long-msg/verifyEcdsaSecp256k1Signature-long-msg.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-long-sig/verifyEcdsaSecp256k1Signature-long-sig.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-short-key/verifyEcdsaSecp256k1Signature-short-key.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-short-msg/verifyEcdsaSecp256k1Signature-short-msg.uplc.budget.expected: Filename too long
error: unable to create file plutus-conformance/test-cases/uplc/evaluation/builtin/semantics/verifyEcdsaSecp256k1Signature/verifyEcdsaSecp256k1Signature-short-sig/verifyEcdsaSecp256k1Signature-short-sig.uplc.budget.expected: Filename too long

@Unisay Unisay added Do not merge EXPERIMENT Experiments that we probably don't want to merge No Changelog Required Add this to skip the Changelog Check labels Jun 14, 2024
@Unisay Unisay self-assigned this Jun 14, 2024
@Unisay Unisay removed Do not merge EXPERIMENT Experiments that we probably don't want to merge labels Jun 14, 2024
@Unisay Unisay marked this pull request as ready for review June 14, 2024 12:34
@Unisay Unisay requested review from kwxm and ana-pantilie June 14, 2024 12:34
@Unisay Unisay enabled auto-merge (squash) June 14, 2024 12:55
@Unisay
Copy link
Contributor Author

Unisay commented Jun 14, 2024

Closing this PR in favour of @kwxm 's solution.

@Unisay Unisay closed this Jun 14, 2024
auto-merge was automatically disabled June 14, 2024 14:15

Pull request was closed

@kwxm kwxm mentioned this pull request Jun 14, 2024
Merged
@zeme-wana zeme-wana deleted the yura/cardano-node-8.1.2 branch June 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ana-pantilie ana-pantilie ana-pantilie approved these changes

@kwxm kwxm Awaiting requested review from kwxm

Assignees

@Unisay Unisay

Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unisay @ana-pantilie