Add pointer to issue on the ledger's cost model interface #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliu41
approved these changes
Mar 11, 2024
Unisay
added a commit
that referenced
this pull request
Mar 18, 2024
…initons. (#5839) * Add pointer to issue on the ledger's cost model interface (#5828) * Agda html (#5827) * Moved all Agda files to Markdown. * Added some brief text to the TOC * Fixed the file extension in Setup.hs for the Markdown Agda. * Added all possible file extensions and the preprocessor seems to run now. * Cleaned out .lagda from the cabal file, since everything is .lagda.md now. * chore(deps): bump tj-actions/changed-files from 42 to 43 (#5835) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 to 43. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v42...v43) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Kwxm/correct conformance comments (#5829) * Fix comments in conformance tests * Fix comments in conformance tests * Fix comments in conformance tests * CIP-57: unroll top level types * Extract `goldenJson` function and move it to the `Tests.Lib` * Note about unrolling types * CIP-57: accumulate schema definitions preserving types for safe refs. * Build schema definitions by un-rolling a list of top-level types. * validatorParameters :: [] --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kenneth MacKenzie <kenneth.mackenzie@iohk.io> Co-authored-by: Ramsay Taylor <ramsay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Unisay
added a commit
that referenced
this pull request
Mar 18, 2024
…initons. (#5839) * Add pointer to issue on the ledger's cost model interface (#5828) * Agda html (#5827) * Moved all Agda files to Markdown. * Added some brief text to the TOC * Fixed the file extension in Setup.hs for the Markdown Agda. * Added all possible file extensions and the preprocessor seems to run now. * Cleaned out .lagda from the cabal file, since everything is .lagda.md now. * chore(deps): bump tj-actions/changed-files from 42 to 43 (#5835) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 to 43. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v42...v43) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Kwxm/correct conformance comments (#5829) * Fix comments in conformance tests * Fix comments in conformance tests * Fix comments in conformance tests * CIP-57: unroll top level types * Extract `goldenJson` function and move it to the `Tests.Lib` * Note about unrolling types * CIP-57: accumulate schema definitions preserving types for safe refs. * Build schema definitions by un-rolling a list of top-level types. * validatorParameters :: [] --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kenneth MacKenzie <kenneth.mackenzie@iohk.io> Co-authored-by: Ramsay Taylor <ramsay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface between the ledger and the Plutus Core cost model is quite complicated (see this Note). This adds a link to the issue where the current form of the interface was decided.