Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0057 Annotations for the PlutusTx.Blueprint.Schema #5820

Merged
merged 1 commit into from
Mar 11, 2024
Merged

CIP-0057 Annotations for the PlutusTx.Blueprint.Schema #5820

merged 1 commit into from
Mar 11, 2024

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Mar 7, 2024

This pull request adds annotations to the PlutusTx.Blueprint.Schema module to provide additional information about schema definitions.

Supersedes #5819

@Unisay Unisay added the No Changelog Required Add this to skip the Changelog Check label Mar 7, 2024
@Unisay Unisay requested a review from zliu41 March 7, 2024 08:47
@Unisay Unisay self-assigned this Mar 7, 2024
@Unisay Unisay mentioned this pull request Mar 7, 2024
Closed
@Unisay Unisay force-pushed the yura/PLT-9658/cip-57-annotations branch from 750c499 to d3947be Compare March 8, 2024 13:09
@Unisay Unisay requested a review from michaelpj March 8, 2024 15:58
@zliu41 zliu41 mentioned this pull request Mar 11, 2024
Merged
zliu41
zliu41 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that #5772 was merged without a changelog, yet it should have one. Can you add the changelog in this PR?

plutus-tx-plugin/test/Blueprint/Tests/Lib.hs Outdated Show resolved Hide resolved
plutus-tx/src/PlutusTx/Blueprint/TH.hs Outdated Show resolved Hide resolved
@Unisay Unisay force-pushed the yura/PLT-9658/cip-57-annotations branch from 63d8ecc to 99769a0 Compare March 11, 2024 14:45
@Unisay Unisay enabled auto-merge (squash) March 11, 2024 14:49
@Unisay Unisay merged commit ce4bcc4 into master Mar 11, 2024
5 checks passed
@Unisay Unisay deleted the yura/PLT-9658/cip-57-annotations branch March 11, 2024 14:59
@zliu41
Copy link
Member

zliu41 commented Mar 11, 2024

@Unisay We still need a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@zliu41 zliu41 zliu41 approved these changes

Assignees

@Unisay Unisay

Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Unisay @zliu41 @michaelpj