-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete plutus-playground #821
Conversation
Deleted all references to |
I think you might be able to delete some purescript stuff also, maybe some of the s-r-ps from cabal.project too? |
a7e440c
to
c32bacf
Compare
Things I'm not sure should be deleted: |
|
||
The Plutus Playground is automatically deployed upon certain pushes to GitHub | ||
|
||
* https://plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io/[Staging] is deployed from every commit pushed to `main` (this URL subject to change) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we actually shutting down those servers? We have our haddock documentation in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From lines 35-40
=== User documentation
The main documentation is located https://plutus-apps.readthedocs.io/en/latest/[here].
The generated Haskell API documentation (haddocks) are here:
<https://playground.plutus.iohkdev.io/doc/haddock>.
These should be sufficient, no?
If so, should be actually ask for plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io
to be shut down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The https://playground.plutus.iohkdev.io/doc/haddock
server hosts the haddock for a released version of plutus-apps. Whereas plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io
hosts the haddock for the main
branch. Both are useful. If you have a better way to restructure this, please suggest :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other places in the README that say where to find the docs, so I think it's safe to delete those lines.
As for a possible restructure: if it works, and both are really useful, I wouldn't change it :)
doc/conf.py
Outdated
.. _Plutus Playground: {0} | ||
.. _Marlowe Playground: {1} | ||
""".format(plutus_playground_url, marlowe_playground_url) | ||
.. _Marlowe Playground: {0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bin
doc/conf.py
Outdated
@@ -13,12 +13,10 @@ | |||
|
|||
# -- Doc config values | |||
marlowe_playground_url = "https://alpha.marlowe.iohkdev.io/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bin
playground-common/ARCHITECTURE.adoc
Outdated
This package contains some library code which is used by the Marlowe Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just delete this statement.
f346e5b
to
5d335f9
Compare
acf5492
to
e397f94
Compare
Hey, sorry for a newbie question, where should I search for the information on reasons for deleting the plutus-playground? Has it been moved somewhere else? |
I have the same question. Is this community not explain anything now? |
@baibinghere |
No description provided.