Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete plutus-playground #821

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Delete plutus-playground #821

merged 1 commit into from
Nov 24, 2022

Conversation

zeme-iohk
Copy link

No description provided.

@zeme-iohk
Copy link
Author

Deleted all references to plutus-playground* and web-ghc
Still needs to refactor playground-common

@michaelpj
Copy link
Contributor

I think you might be able to delete some purescript stuff also, maybe some of the s-r-ps from cabal.project too?

@zeme-iohk zeme-iohk force-pushed the zeme-iohk/remove-pg branch 2 times, most recently from a7e440c to c32bacf Compare November 22, 2022 14:28
@zeme-iohk
Copy link
Author

Things I'm not sure should be deleted:
doc/plutus/tutorials/basic-apps.rst
doc/plutus/tutorials/HelloWorldApp.hs


The Plutus Playground is automatically deployed upon certain pushes to GitHub

* https://plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io/[Staging] is deployed from every commit pushed to `main` (this URL subject to change)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we actually shutting down those servers? We have our haddock documentation in there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From lines 35-40

=== User documentation

The main documentation is located https://plutus-apps.readthedocs.io/en/latest/[here].

The generated Haskell API documentation (haddocks) are here:
<https://playground.plutus.iohkdev.io/doc/haddock>.

These should be sufficient, no?
If so, should be actually ask for plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io to be shut down?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The https://playground.plutus.iohkdev.io/doc/haddock server hosts the haddock for a released version of plutus-apps. Whereas plutus-playground-plutus-apps-staging.plutus.aws.iohkdev.io hosts the haddock for the main branch. Both are useful. If you have a better way to restructure this, please suggest :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places in the README that say where to find the docs, so I think it's safe to delete those lines.
As for a possible restructure: if it works, and both are really useful, I wouldn't change it :)

doc/conf.py Outdated
.. _Plutus Playground: {0}
.. _Marlowe Playground: {1}
""".format(plutus_playground_url, marlowe_playground_url)
.. _Marlowe Playground: {0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin

doc/conf.py Outdated
@@ -13,12 +13,10 @@

# -- Doc config values
marlowe_playground_url = "https://alpha.marlowe.iohkdev.io/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin

This package contains some library code which is used by the Marlowe Playground.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just delete this statement.

@zeme-iohk zeme-iohk force-pushed the zeme-iohk/remove-pg branch 2 times, most recently from f346e5b to 5d335f9 Compare November 23, 2022 14:42
@andreabedini
Copy link
Contributor

image

This must be a new record :D

@zeme-iohk zeme-iohk marked this pull request as ready for review November 24, 2022 11:51
@zeme-iohk zeme-iohk merged commit ea11827 into main Nov 24, 2022
@zeme-iohk zeme-iohk deleted the zeme-iohk/remove-pg branch November 24, 2022 12:30
@Zaczero
Copy link

Zaczero commented Dec 13, 2022

Hey, sorry for a newbie question, where should I search for the information on reasons for deleting the plutus-playground? Has it been moved somewhere else?

@baibinghere
Copy link

I have the same question. Is this community not explain anything now?

@eric248550
Copy link

eric248550 commented Dec 28, 2022

@baibinghere
plutus-playground is no longer maintained by IOG
#653 (comment)

Screen Shot 2022-12-28 at 6 33 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants