Add marconi-mamba package #724

eyeinsky · 2022-09-27T09:37:15Z

Todos

17e937a ~~wire up nix~~
01154c4 ~~where to get ChainPoint from, cli?~~
Comment added fa13a9b ~~the NetworkId parser is copy-paste from cardano-node/cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs::1883, add todo to import it instead whenever it's exported?~~
rebased this onto main, while cherry-picked the required commints from unmerged ml/plt-647 ~~get ml/plt-647 merged prior to this one and base this PR on main instead (It's based on ml/plt-647 because that exposes the Address->Utxo indexer as a library)~~

Pre-submit checklist:

Branch
- Tests are provided (if possible)
- Commit sequence broadly makes sense
- Key commits have useful messages
- Formatting, PNG optimization, etc. are updated
PR
- Self-reviewed the diff
- Useful pull request description
- Reference the ADR in the PR and reference the PR in the ADR (if revelant)
- Reviewer requested

eyeinsky · 2022-09-27T12:24:40Z

@zeme-iohk Could you help set this up in our nix configuration?

zeme-iohk · 2022-09-28T15:12:15Z

You want to add the LICENSE and NOTICE files inside the marconi-mamba folder, or the nix build will fail.
Then you want to add this:
marconi-mamba = plutus-apps.haskell.packages.marconi-mamba.components.exes.marconi-mamba;
below line 67 in default.nix.
Then, users will be able to run nix build .#marconi-mamba to build the executable

eyeinsky · 2022-09-30T10:56:50Z

This PR is now based on main and not on #714, because the latter still has issues and it would be easier to get this merged so that @kayvank can get his PR #727 also merged.

Cherry-picked the commits from #714 that this branch needed, namely the first four: cf5b91f, 11d65a9, 84634a6, 6471cc1.

kayvank

looks good to me

koslambrou · 2022-09-30T13:12:58Z

@eyeinsky Also add the package in the relevant places in nix/pkgs/haskell/haskell.nix. Base on what we do with marconi.

raduom

I am not sure about all the nix things, but otherwise it looks good.

raduom · 2022-09-30T13:19:01Z

marconi-mamba/marconi-mamba.cabal

+    -Wnoncanonical-monad-instances -Wredundant-constraints
+    -Wunused-packages
+
+executable marconi-mamba


Do we also want a library for this one?

eyeinsky · 2022-09-30T13:38:11Z

CI error: {UNKNOWN}: Died at /nix/store/gwfrn3w2caqdjr7a6vkkcix60r8svvy2-hydra-0.1.20220215.e49dd9c/bin/.hydra-eval-jobset-wrapped line 813. at /nix/store/7r0iilv1hr4nbcgdw2gfgm2slap9hbpk-hydra-perl-deps/lib/perl5/site_perl/5.32.1/Catalyst/Model/DBIC/Schema.pm line 526 (link)

koslambrou · 2022-09-30T14:00:48Z

CI error: {UNKNOWN}: Died at /nix/store/gwfrn3w2caqdjr7a6vkkcix60r8svvy2-hydra-0.1.20220215.e49dd9c/bin/.hydra-eval-jobset-wrapped line 813. at /nix/store/7r0iilv1hr4nbcgdw2gfgm2slap9hbpk-hydra-perl-deps/lib/perl5/site_perl/5.32.1/Catalyst/Model/DBIC/Schema.pm line 526 (link)

Did you try updating the file I mentioned above?

eyeinsky · 2022-10-03T11:59:19Z

CI now fails for the fix I added for darwin/mac minis here by not being able to create a directory under /tmp

koslambrou · 2022-10-03T18:09:18Z

@eyeinsky Had the same problem in this PR: #728

Tried re-running Hydra and see if anything changes.

koslambrou · 2022-10-05T14:34:59Z

@eyeinsky You can fix the conflicts and update on main, as the darwin checks have been disabled

This reverts commit 8e4e558.

eyeinsky · 2022-10-05T16:26:05Z

Got this rebased onto latest main, builds locally, waiting for CI to finish.

kayvank · 2022-10-05T19:00:30Z

marconi-mamba/app/Main.hs

+
+args :: Opt.Parser Args
+args = Args
+  <$> Opt.strOption (Opt.long "socket" <> Opt.metavar "FILE" <> Opt.help "Socket path to node")


the cli is socket-path and it would be goo to remain consistent.

eyeinsky · 2022-10-06T12:02:37Z

@koslambrou this can be merged, right?

koslambrou · 2022-10-06T12:03:22Z

@koslambrou this can be merged, right?

Yep!

* Add marconi-mamba package * Add comment for where opt farser for NetworkId is gotten from * Add Marconi.CLI module, move `chainPointParser` to it * Parse ChainPoint from cli * Add LICENCE and NOTICE files * Add marconi-mamba to default.nix * Add marconi-mamba to nix/pkgs/haskell/haskell.nix * Add library section

eyeinsky force-pushed the ml/plt-861 branch from 01154c4 to 35efc41 Compare September 27, 2022 15:55

eyeinsky force-pushed the ml/plt-861 branch from 5fcb34c to 17e937a Compare September 30, 2022 10:49

eyeinsky changed the base branch from ml/plt-647 to main September 30, 2022 10:50

eyeinsky requested review from kayvank, raduom and koslambrou September 30, 2022 11:04

eyeinsky marked this pull request as ready for review September 30, 2022 11:05

kayvank approved these changes Sep 30, 2022

View reviewed changes

raduom approved these changes Sep 30, 2022

View reviewed changes

eyeinsky force-pushed the ml/plt-861 branch 3 times, most recently from adc49c9 to fb5ce8d Compare September 30, 2022 16:04

eyeinsky mentioned this pull request Sep 30, 2022

862/marconi mamba json rpc endpoint #727

Merged

2 tasks

eyeinsky added 8 commits October 5, 2022 17:42

Add marconi-mamba package

c633566

Add comment for where opt farser for NetworkId is gotten from

f3a633d

Add Marconi.CLI module, move chainPointParser to it

d89b189

Parse ChainPoint from cli

49616fd

Add LICENCE and NOTICE files

cdeb7c2

Add marconi-mamba to default.nix

a360394

Add marconi-mamba to nix/pkgs/haskell/haskell.nix

0ab1456

Add library section

0199097

eyeinsky added 3 commits October 5, 2022 17:47

[tmp] Trigger CI rerun

2851865

Revert "[tmp] Trigger CI rerun"

8398426

This reverts commit 8e4e558.

fixup! Add marconi-mamba package

acb2ceb

eyeinsky force-pushed the ml/plt-861 branch from 85dcab6 to acb2ceb Compare October 5, 2022 15:01

eyeinsky added 2 commits October 5, 2022 18:47

fixup! Add Marconi.CLI module, move chainPointParser to it

f7efb8c

fixup! Add marconi-mamba package

6ac1ac3

kayvank reviewed Oct 5, 2022

View reviewed changes

fixup! Add marconi-mamba package

d12300f

eyeinsky merged commit e882efc into main Oct 6, 2022

eyeinsky deleted the ml/plt-861 branch October 6, 2022 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add marconi-mamba package #724

Add marconi-mamba package #724

eyeinsky commented Sep 27, 2022 •

edited

Loading

eyeinsky commented Sep 27, 2022

zeme-iohk commented Sep 28, 2022 •

edited

Loading

eyeinsky commented Sep 30, 2022 •

edited

Loading

kayvank left a comment

koslambrou commented Sep 30, 2022 •

edited

Loading

raduom left a comment

raduom Sep 30, 2022

koslambrou Sep 30, 2022

eyeinsky commented Sep 30, 2022

koslambrou commented Sep 30, 2022

eyeinsky commented Oct 3, 2022

koslambrou commented Oct 3, 2022

koslambrou commented Oct 5, 2022

eyeinsky commented Oct 5, 2022

kayvank Oct 5, 2022

eyeinsky Oct 6, 2022

eyeinsky commented Oct 6, 2022

koslambrou commented Oct 6, 2022

Add marconi-mamba package #724

Add marconi-mamba package #724

Conversation

eyeinsky commented Sep 27, 2022 • edited Loading

eyeinsky commented Sep 27, 2022

zeme-iohk commented Sep 28, 2022 • edited Loading

eyeinsky commented Sep 30, 2022 • edited Loading

kayvank left a comment

Choose a reason for hiding this comment

koslambrou commented Sep 30, 2022 • edited Loading

raduom left a comment

Choose a reason for hiding this comment

raduom Sep 30, 2022

Choose a reason for hiding this comment

koslambrou Sep 30, 2022

Choose a reason for hiding this comment

eyeinsky commented Sep 30, 2022

koslambrou commented Sep 30, 2022

eyeinsky commented Oct 3, 2022

koslambrou commented Oct 3, 2022

koslambrou commented Oct 5, 2022

eyeinsky commented Oct 5, 2022

kayvank Oct 5, 2022

Choose a reason for hiding this comment

eyeinsky Oct 6, 2022

Choose a reason for hiding this comment

eyeinsky commented Oct 6, 2022

koslambrou commented Oct 6, 2022

eyeinsky commented Sep 27, 2022 •

edited

Loading

zeme-iohk commented Sep 28, 2022 •

edited

Loading

eyeinsky commented Sep 30, 2022 •

edited

Loading

koslambrou commented Sep 30, 2022 •

edited

Loading