Fix Ledger.Constraints.TxConstraints.collectFromPlutusV1ScriptFilter implementation #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 4, 2022
…sV1ScriptFilter` and `Ledger.Constraints.TxConstraints.collectFromTheScript` as unrelated functions. The rationale is that if someone uses `collectFromPlutusV1ScriptFilter`, the constraints will fail with a `TypedValidatorMissing` error for lookups, even though we're not using typed validators.
koslambrou
force-pushed
the
kll/fix-collectFromPlutusV1ScriptFilter
branch
from
b2b42fc
to
5c0110a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the functions
Ledger.Constraints.TxConstraints.collectFromPlutusV1ScriptFilterandLedger.Constraints.TxConstraints.collectFromTheScriptas unrelated functions.The rationale is that if someone uses
collectFromPlutusV1ScriptFilter,the constraints will fail with a
TypedValidatorMissingerror forlookups, even though we're not using typed validators.
This fix was triggered by #641
Pre-submit checklist: