Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build-and-serve-docs to CONTRIBUTING... #595

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Add build-and-serve-docs to CONTRIBUTING... #595

merged 2 commits into from
Jul 14, 2022

Conversation

catch-21
Copy link
Contributor

... and docs README

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@catch-21 catch-21 marked this pull request as ready for review July 14, 2022 15:15
@catch-21 catch-21 requested a review from michaelpj July 14, 2022 15:15
@michaelpj michaelpj merged commit de954bc into main Jul 14, 2022
@michaelpj michaelpj deleted the note-build-and-serve-docs branch July 14, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catch-21 @michaelpj