Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README_alpha-release_Marconi.md #591

Merged
merged 12 commits into from
Jul 14, 2022

Conversation

joseph-fajen
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@joseph-fajen joseph-fajen marked this pull request as ready for review July 13, 2022 14:30
@@ -0,0 +1,75 @@
![Marconi-Logo_sm](https://user-images.githubusercontent.com/104791413/178748103-077ed7e0-6071-461f-b9ed-97b3b7bd5b24.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, but that's okay :D

plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
@@ -0,0 +1,75 @@
![Marconi-Logo_sm](https://user-images.githubusercontent.com/104791413/178748103-077ed7e0-6071-461f-b9ed-97b3b7bd5b24.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually have no idea why this is called Marconi so I have no idea if the logo fits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since IOG has a tradition of using famous scientists for product names (Ada, Cardano, Basho, Goguen, etc.). Marconi is a famous italian scientist. https://en.wikipedia.org/wiki/Guglielmo_Marconi

I don't think the logo has to fit the person. Similar with Cardano; it's logo doesn't really fit.

Copy link
Contributor Author

@joseph-fajen joseph-fajen Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first idea that we explored with a graphic designer. I basically like it. Taking on logo design can be a big project, and mostly I'm happy we have something we can use. I think it's worth asking the deeper question of what the logo should truly be. But the nuts and bolts of going through a true design process can be very time consuming. Maybe we could consider taking suggestions from the whole team. Could be a rabbit hole though!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logo represents a radio which Marconi invented.

plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
plutus-chain-index/README_alpha-release_Marconi.md Outdated Show resolved Hide resolved
joseph-fajen and others added 8 commits July 13, 2022 13:40
Co-authored-by: koslambrou <konstantinos.lambrou@iohk.io>
Co-authored-by: koslambrou <konstantinos.lambrou@iohk.io>
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Incorporating comments received so far. Some comments/suggested content from Radu seems to have disappeared, so I've asked Radu to post them again.
@joseph-fajen joseph-fajen requested a review from raduom July 13, 2022 23:27
joseph-fajen and others added 2 commits July 13, 2022 22:36
Radu's most recent additional content

Co-authored-by: Radu Ometita <radu.ometita@gmail.com>
Adding content from Radu, additional piece
Copy link
Contributor Author

@joseph-fajen joseph-fajen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been incorporated as of July 13 10:50pm PST

@raduom raduom enabled auto-merge (squash) July 14, 2022 05:58
@raduom raduom merged commit 4cc6c84 into main Jul 14, 2022
@raduom raduom deleted the josfaj-PLT-560-alpha-release-readme branch July 14, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants