PLT-271: Use of pure cardano-api transaction in emulator #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
force-pushed
the
PLT-271-cardano-api-tx-only-in-emulator
branch
from
eddec40
to
7700412
Compare
koslambrou
reviewed
Jun 12, 2022
| setValidity :: Bool -> C.Tx era -> C.Tx era | ||
| setValidity validity (C.Tx (C.ShelleyTxBody C.ShelleyBasedEraAlonzo txBody scripts dat aux _) era) = | ||
| C.Tx (C.ShelleyTxBody C.ShelleyBasedEraAlonzo txBody scripts dat aux (toTxScriptValidity validity)) era | ||
| setValidity _ tx = tx -- only applies in Alonzo era |
There was a problem hiding this comment.
I don't understand the comment. You mean this "applies to eras pre-Alonzo"?
koslambrou
reviewed
Jun 12, 2022
| (fromOnChainCardanoTx False) | ||
| ctx | ||
|
|
||
| fromOnChainCardanoTx :: Bool -> SomeCardanoApiTx -> ChainIndexTx |
There was a problem hiding this comment.
Comment on why we need to manually set the script validity when converting from CardanoTx to ChainIndexTx?
koslambrou
reviewed
Jun 12, 2022
| pure (e, events) | ||
|
|
||
| validateL :: Params -> Slot -> Validation.UTxO Index.EmulatorEra -> SomeCardanoApiTx -> Maybe Index.ValidationErrorInPhase | ||
| validateL params slot idx (CardanoApiEmulatorEraTx tx) = Validation.hasValidationErrors params (fromIntegral slot) idx tx | ||
| -- TODO: generate ScriptValidationEvents |
There was a problem hiding this comment.
What do that refer to exactly? Do we have a story for that?
There was a problem hiding this comment.
Good point, I will make one.
koslambrou
approved these changes
Jun 12, 2022
|
LGTM :) |
ghost
approved these changes
Jun 13, 2022
koslambrou
pushed a commit
that referenced
this pull request
Jun 22, 2022
* Deeper support for Cardano API Tx's in the emulator * Implement getCardanoTxData * Update Utxo index for cardano api txs * Restore normal behavior * Add a testcase * Remove NFData instance, it seems to be unused * Fix build * Remove acidental change * Generate PureScript * Revert Rollup changes and throw error instead * Fix temp change * plutus-chain-index: Use fromCardanoTx in fromOnChainTx * plutus-chain-index: with Both, use emulator tx in fromOnChainTx * Fix build * PR and Hoogle feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual new code is mostly just the changes in plutus-ledger/src/Ledger/Tx.hs.
The big change is that the emulated blockchain now also contains
CardanoTx, so either transaction type or both.Pre-submit checklist: