PLT-255 Fixed plutus-pab integration test #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
commented
Jun 3, 2022
koslambrou
commented
Jun 3, 2022
koslambrou
force-pushed
the
PLT-255-gth-473-plutus-pab-integration-test-failure-with-local-cluster
branch
from
ac6b878
to
632e82e
Compare
* Reorganized the placement of some functions * Fixed the `awaitSlot` blockchain action in `plutus-pab` as it wasn't working. It was using as reference the slot of the last synced block instead of the actual current slot. * Patched temporarly the PubKey contract so that it waits a bit before querying the chain-index. In the future, once we fix the discrepancy between information shared between plutus-pab and plutus-chain-index, this should be removed. * Fixed the number of events that are processed by plutus-chain-index once we are in sync with the local node. The reason is that once we are fully in sync with the local node, we want to process as much information as possible and not wait for the queue to be filled.
koslambrou
force-pushed
the
PLT-255-gth-473-plutus-pab-integration-test-failure-with-local-cluster
branch
from
632e82e
to
509722c
Compare
ghost
approved these changes
Jun 6, 2022
plutus-pab/src/Plutus/PAB/Core/ContractInstance/BlockchainEnv.hs
Outdated
Show resolved
Hide resolved
* Reorganized the placement of some functions * Fixed the `awaitSlot` blockchain action in `plutus-pab` as it wasn't working. It was using as reference the slot of the last synced block instead of the actual current slot. * Patched temporarly the PubKey contract so that it waits a bit before querying the chain-index. In the future, once we fix the discrepancy between information shared between plutus-pab and plutus-chain-index, this should be removed. * Fixed the number of events that are processed by plutus-chain-index once we are in sync with the local node. The reason is that once we are fully in sync with the local node, we want to process as much information as possible and not wait for the queue to be filled.
koslambrou
force-pushed
the
PLT-255-gth-473-plutus-pab-integration-test-failure-with-local-cluster
branch
from
be13104
to
7c86a8e
Compare
koslambrou
deleted the
PLT-255-gth-473-plutus-pab-integration-test-failure-with-local-cluster
branch
koslambrou
added a commit
that referenced
this pull request
Jun 22, 2022
* PLT-255 Fixed plutus-pab integration test * Reorganized the placement of some functions * Fixed the `awaitSlot` blockchain action in `plutus-pab` as it wasn't working. It was using as reference the slot of the last synced block instead of the actual current slot. * Patched temporarly the PubKey contract so that it waits a bit before querying the chain-index. In the future, once we fix the discrepancy between information shared between plutus-pab and plutus-chain-index, this should be removed. * Fixed the number of events that are processed by plutus-chain-index once we are in sync with the local node. The reason is that once we are fully in sync with the local node, we want to process as much information as possible and not wait for the queue to be filled. * PLT-255 Fixed plutus-pab integration test * Reorganized the placement of some functions * Fixed the `awaitSlot` blockchain action in `plutus-pab` as it wasn't working. It was using as reference the slot of the last synced block instead of the actual current slot. * Patched temporarly the PubKey contract so that it waits a bit before querying the chain-index. In the future, once we fix the discrepancy between information shared between plutus-pab and plutus-chain-index, this should be removed. * Fixed the number of events that are processed by plutus-chain-index once we are in sync with the local node. The reason is that once we are fully in sync with the local node, we want to process as much information as possible and not wait for the queue to be filled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #451 and fix #473
Reorganized the placement of some functions
Fixed the
awaitSlotblockchain action inplutus-pabas it wasn'tworking. It was using as reference the slot of the last synced block
instead of the actual current slot.
Patched temporarly the PubKey contract so that it waits a bit before
querying the chain-index. In the future, once we fix the discrepancy
between information shared between plutus-pab and plutus-chain-index,
this should be removed.
Fixed the number of events that are processed by plutus-chain-index
once we are in sync with the local node. The reason is that once we
are fully in sync with the local node, we want to process as much
information as possible and not wait for the queue to be filled.
Pre-submit checklist: