Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-3631: Make protocolParameters configurable #455

Merged
merged 11 commits into from
May 18, 2022
Merged

SCP-3631: Make protocolParameters configurable #455

merged 11 commits into from
May 18, 2022

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented May 11, 2022 •
edited
Loading

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher marked this pull request as ready for review May 16, 2022 15:09
@sjoerdvisscher sjoerdvisscher requested review from koslambrou and a user May 16, 2022 15:26
koslambrou
koslambrou requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@koslambrou koslambrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most the tests have activated the allowBigTransactions option. Is that a good thing? Does it mean that the examples will not work on the current Cardano network.

plutus-contract/src/Plutus/Contract/Test.hs Show resolved Hide resolved
plutus-contract/src/Plutus/Contract/Test/ContractModel/Internal.hs Outdated Show resolved Hide resolved
plutus-ledger/src/Ledger/Params.hs Show resolved Hide resolved
plutus-ledger/src/Ledger/Params.hs Outdated Show resolved Hide resolved
plutus-ledger/src/Ledger/TimeSlot.hs Show resolved Hide resolved
@sjoerdvisscher
Copy link
Contributor Author

Does it mean that the examples will not work on the current Cardano network.

It does. Basically anything using the state machine library is too big. And some of the other bigger contracts too.

ghost
ghost approved these changes May 17, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a half of my #419 because I had to pass protocol params in the same places.

Resolving conflicts will be fun.

plutus-use-cases/test/Spec/Governance.hs Show resolved Hide resolved
@catch-21 catch-21 mentioned this pull request May 17, 2022
Closed
@koslambrou
Copy link
Contributor

Nice work @sjoerdvisscher !

@sjoerdvisscher sjoerdvisscher merged commit e51f57f into main May 18, 2022
@sjoerdvisscher sjoerdvisscher deleted the SCP-3631-Params branch May 18, 2022 13:44
koslambrou pushed a commit that referenced this pull request Jun 22, 2022
@sjoerdvisscher @koslambrou
SCP-3631: Make protocolParameters configurable (#455)
e257739 
* WIP

* Pass around Params instead of SlotConfig

* Use Params in Ledger.Validation

* Implement collateralPercent

* Use alternative protocol parameters for some bigger test cases.

* Restore all use case tests

* PR feedback

* Don't enable "allowBigTransactions" by default for contract model testing

* Fix pab test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koslambrou koslambrou koslambrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoerdvisscher @koslambrou