Remove updateMaterialized #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raduom
force-pushed
the
raduom/no-updateMaterialized
branch
from
ebc2e8e
to
e66a46c
Compare
raduom
force-pushed
the
raduom/no-updateMaterialized
branch
from
e66a46c
to
d1d7778
Compare
|
It does look like it made hydra evals longer, but not drastically: 149s to 254s |
michaelpj
approved these changes
Apr 27, 2022
|
As an update, it also makes macos disk usage much more predictable. |
koslambrou
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cut & paste of the similar fix @michaelpj did for plutus. Note that beside the execution times on hydra, etc. this may also improve the space used for builds on macs where I recently had a lot of trouble (/nix grows to around 500Gb eventually). I noticed how
updateMaterializedseems to add around 80Gb everytime it is ran, and it does not remove the used space after running.I have yet to test how this works on mac, but on pc/linux I did not notice any significant delays.
Pre-submit checklist: