Allow chain-index to print silently. #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit adds a new definition `Plutus.ChainIndex.App (runMainWithLog)` allowing to run chain-index with different function to do startup logs.
|
Only the logs when starting the chain-index bother you and not the syncing logs? |
|
I missed the syncing logs, thanks. They bother me as well, but these are logged using proper logging machinery so I hope I can silence them with different |
|
I fixed the formatting. Could we run workflows and possibly merge afterwards? |
|
@koslambrou Hey! I'm just wondering, could this PR be reviewed and merged? |
koslambrou
approved these changes
May 12, 2022
koslambrou
pushed a commit
that referenced
this pull request
Jun 22, 2022
* Allow chain-index to print silently. Commit adds a new definition `Plutus.ChainIndex.App (runMainWithLog)` allowing to run chain-index with different function to do startup logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Pr adds a new definition
Plutus.ChainIndex.App (runMainWithLog)allowing to run chain-index with different function to do startup logs and refactorsrunMainto use this definition. This is a tiny commit.explanation
In plutip - a tool to spin up a testnet and run contracts - we call chain-index's main function (from code with
runMain) as one of the components. It does logging at startup to stdout and these logs get mixed up with the rest of the logs. Running it in a new process is troublesome, so I am asking if I could just add this small change to chain-index itself.