Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ContractModel tutorial #399

Merged
merged 21 commits into from
Apr 13, 2022
Merged

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Apr 6, 2022

This PR introduces a new ContractModel tutorial.

Most of the material is in place already but due to some delays on our end there are some additions later. Some of these are hinted in the tutorial right now but that should not hamper readability until we've finalized the last sections.

I think it makes sense to start reviewing and merging this as soon as possible regardless of this, as this is already 60 A4 pages of material :)

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher do you understand why there are diffs with main, I rebased and they're still there...

@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher Also, do you understand the error in the tutorial build system? It appears to be complaining that plutus/tutorials/Escrow.html doesn't exist in the doc directory - but it most certainly does!

@sjoerdvisscher
Copy link
Contributor

@MaximilianAlgehed Try fetching and rebasing again, there are definitely still changes.

For the build error: you need to add ".html" to the sourceFilesBySuffices list in docs/default.nix.

@sjoerdvisscher sjoerdvisscher merged commit 03ba6b7 into IntersectMBO:main Apr 13, 2022
@UlfNorell UlfNorell deleted the PR-tutorial branch April 13, 2022 11:12
raduom pushed a commit to raduom/plutus-apps that referenced this pull request Apr 21, 2022
* Small changes to Uniswap model; test out-of-order tokens

* Changes to GameStateMachine generation

* Add some negative testing to Spec.Uniswap

* Add HTML coverage reporting for on-chain coverage info

* First push on tutorial

* Add ...WithOptions versions of checkNoLockedFundsProof(Fast)

* Add No Locked Funds tutorial

* checkNoLockedFundsProof: only run the wallet strategy for wallets with something to gain.

* DynamicLogic: make anyActions_ generate a length depending on size parameter

* Add time awareness section to the tutorial

* Add coverage section to the tutorial

* Make nextReactiveState and monitoring work in CrashTolerance tests

* Add crash tolerance to the tutorial

* Add ghc options to Auction.hs

* Update tutorial Escrow specs to compile again

* Add section on Auction to the tutorial

* Enable SymValue in Actions (by deriving Data)

* Add actionName to ContractModel

* ContractModel: check *all* wallet balances, not just those changed in the model

* Short section about certification in tutorial

* fixed build errors in tutorial modules and ran updateMaterialized

Co-authored-by: John <john.hughes@quviq.com>
raduom pushed a commit to raduom/plutus-apps that referenced this pull request Apr 27, 2022
* Small changes to Uniswap model; test out-of-order tokens

* Changes to GameStateMachine generation

* Add some negative testing to Spec.Uniswap

* Add HTML coverage reporting for on-chain coverage info

* First push on tutorial

* Add ...WithOptions versions of checkNoLockedFundsProof(Fast)

* Add No Locked Funds tutorial

* checkNoLockedFundsProof: only run the wallet strategy for wallets with something to gain.

* DynamicLogic: make anyActions_ generate a length depending on size parameter

* Add time awareness section to the tutorial

* Add coverage section to the tutorial

* Make nextReactiveState and monitoring work in CrashTolerance tests

* Add crash tolerance to the tutorial

* Add ghc options to Auction.hs

* Update tutorial Escrow specs to compile again

* Add section on Auction to the tutorial

* Enable SymValue in Actions (by deriving Data)

* Add actionName to ContractModel

* ContractModel: check *all* wallet balances, not just those changed in the model

* Short section about certification in tutorial

* fixed build errors in tutorial modules and ran updateMaterialized

Co-authored-by: John <john.hughes@quviq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants