Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate the SigningProcess API #384

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Reinstate the SigningProcess API #384

merged 1 commit into from
Apr 1, 2022

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Mar 30, 2022

Fixes #373

I thought the SigningProcess code was old and should be removed. But after reading the "Control effects" note in MultiAgent.hs it actually made sense to me to have this, to emulate "outside the contract" signing processes, like emailing the transaction around for signatures.

So fixed it to let it have an effect again, and also fixed that it workes with the cardano-ledger validation.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@koslambrou koslambrou merged commit 75f0acd into main Apr 1, 2022
@koslambrou koslambrou deleted the sv/signing-process branch April 1, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SigningProcess seems to not effect the ScriptContext in the emulator
2 participants