Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When breaking off the calcFee recursion, pick the larger fee. #381

Merged
merged 1 commit into from
Mar 30, 2022
Merged

When breaking off the calcFee recursion, pick the larger fee. #381

merged 1 commit into from
Mar 30, 2022

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Mar 29, 2022 •
edited
Loading

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@sjoerdvisscher
Copy link
Contributor Author

@koslambrou Issue reported by John Hughes, he has confirmed that this fixes his issue.

@koslambrou koslambrou merged commit 1e82e34 into main Mar 30, 2022
@koslambrou koslambrou deleted the fix/fee-calculation-fix branch March 30, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koslambrou koslambrou koslambrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoerdvisscher @koslambrou