-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certification framework #369
Certification framework #369
Conversation
@sjoerdvisscher do you know what's up with the failing GitHub checks? |
@MaximilianAlgehed Yes, the macs have been updated causing the builds to fail. IntersectMBO/plutus#4497 works around this, so rebasing on main should fix this. |
Create separate plutus-contract-certification library. This will enable the certification service to swap in newer source-compatible versions. Should perhaps include all of Plutus.Contract.Test
acd1d7c
to
51b334a
Compare
@sjoerdvisscher I rebased on |
I think you need to do this thing:
|
Thanks :) |
That appears to have changed nothing :(
|
I ran the nix build locally and it did report an error:
Hopefully then everything builds except check-for-updates. |
I created a PR to your branch with some fixes: Quviq#3 |
Ok, one more thing to try: could you add |
Finally! The failing plutus-use-case is fixed on main. @koslambrou can you merge this please? |
* First iteration of certification framework Create separate plutus-contract-certification library. This will enable the certification service to swap in newer source-compatible versions. Should perhaps include all of Plutus.Contract.Test * unit tests coverage in certification * Add some modest haddock comments * Fix build * SJV's suggested fix Co-authored-by: Maximilian Algehed <m.algehed@gmail.com> Co-authored-by: Sjoerd Visscher <sjoerd.visscher@iohk.io>
Thanks! I'll have a look at these and try to get this up to speed once I'm
by my computer.
…On Sun, 27 Mar 2022, 13:12 Sjoerd Visscher, ***@***.***> wrote:
I created a PR to your branch with some fixes: Quviq#3
<Quviq#3>
—
Reply to this email directly, view it on GitHub
<#369 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBPPQKY76SNSKNMMRDQ4N3VCBGBFANCNFSM5RLBUV6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Framework for level 1 certification.
Pre-submit checklist: