Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certification framework #369

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

UlfNorell
Copy link
Contributor

@UlfNorell UlfNorell commented Mar 22, 2022

Framework for level 1 certification.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed
Copy link
Contributor

@sjoerdvisscher do you know what's up with the failing GitHub checks?

@sjoerdvisscher
Copy link
Contributor

@MaximilianAlgehed Yes, the macs have been updated causing the builds to fail. IntersectMBO/plutus#4497 works around this, so rebasing on main should fix this.

UlfNorell and others added 3 commits March 23, 2022 13:20
Create separate plutus-contract-certification library.

This will enable the certification service to swap in newer source-compatible versions.

Should perhaps include all of Plutus.Contract.Test
@MaximilianAlgehed
Copy link
Contributor

@sjoerdvisscher I rebased on main but it appears to still be failing!

@sjoerdvisscher
Copy link
Contributor

I think you need to do this thing:

*** Please run plutus-playground-generate-purs
*** in plutus-playground-client and
*** pab-nami-demo-generate-purs in
*** plutus-pab-executables/demo/pab-nami/client and and commit changes.

@MaximilianAlgehed
Copy link
Contributor

Thanks :)

@MaximilianAlgehed
Copy link
Contributor

That appears to have changed nothing :(

[nix-shell:~/IOHK/plutus-apps]$ git status
On branch PR-certification-framework
Your branch is up to date with 'origin/PR-certification-framework'.

nothing to commit, working tree clean

@sjoerdvisscher
Copy link
Contributor

I ran the nix build locally and it did report an error:

src/Plutus/Contract/Test/Certification.hs:7:1: warning: [-Wunused-imports]
     The import of ‘Plutus.Contract.Test.Coverage’ is redundant

Hopefully then everything builds except check-for-updates.

@sjoerdvisscher
Copy link
Contributor

I created a PR to your branch with some fixes: Quviq#3

@sjoerdvisscher
Copy link
Contributor

Ok, one more thing to try: could you add plutus-contract-certification.package.buildable = false; at line 64 in haskell.nix?

@sjoerdvisscher
Copy link
Contributor

Finally! The failing plutus-use-case is fixed on main. @koslambrou can you merge this please?

@koslambrou koslambrou merged commit 521484e into IntersectMBO:main Mar 29, 2022
bwbush pushed a commit that referenced this pull request Apr 15, 2022
* First iteration of certification framework

Create separate plutus-contract-certification library.

This will enable the certification service to swap in newer source-compatible versions.

Should perhaps include all of Plutus.Contract.Test

* unit tests coverage in certification

* Add some modest haddock comments

* Fix build

* SJV's suggested fix

Co-authored-by: Maximilian Algehed <m.algehed@gmail.com>
Co-authored-by: Sjoerd Visscher <sjoerd.visscher@iohk.io>
@MaximilianAlgehed
Copy link
Contributor

MaximilianAlgehed commented Oct 11, 2022 via email

@MaximilianAlgehed MaximilianAlgehed deleted the PR-certification-framework branch January 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants