Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile #361

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Added Dockerfile #361

merged 1 commit into from
Mar 21, 2022

Conversation

agocorona
Copy link
Contributor

@agocorona agocorona commented Mar 15, 2022

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@agocorona
Copy link
Contributor Author

agocorona commented Mar 15, 2022

I included a Dockerfile which creates a image where nix-shell initializes at build time, so that the image created start quickly with nix-shell as default shell with the plutus-apps source available to be navigated with VSCode, ready for cabal build

plutus-starter sould have been the way to use docker for all the Plutus related development but the docker image provided in plutus-starter does not work with new versions of VSCode and the remote extension. Additionally. the plutus-starter image is not ready with plutus code ready for compilation.

Since a Docker box may have limited memory, I recommend cabal build -j1 to avoid memory exhaustion problems

@koslambrou
Copy link
Contributor

LGTM, thanks for contributing!

@koslambrou koslambrou merged commit ec8c81a into IntersectMBO:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants