Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractModel: wellformedness checks for Actions #345

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Mar 4, 2022

This PR introduces some checks that actions are well formed and don't refer to symbolic tokens that don't exist. A Data.Data based automatic predicate checks that no symtokens that aren't bound are used in actions and there is a possibility for the programmer to override this functionality with their own custom function (in case there is an issue with Data.Data). This means that issues like the one encountered in #342 don't affect developers and my "workaround" there isn't necessary.

Furthermore, this PR updates the dependency on plutus-core because we need instances of Data.Data for a number of types in plutus-core.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft March 4, 2022 09:16
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-symtoken-wellformedness-constraints branch from d65b86c to 116e903 Compare March 7, 2022 14:27
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-symtoken-wellformedness-constraints branch from 609d07d to 10ebb22 Compare March 8, 2022 10:05
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review March 8, 2022 10:25
@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher when you have the time this is ready :)

@sjoerdvisscher sjoerdvisscher merged commit c4960ae into IntersectMBO:main Mar 8, 2022
bwbush pushed a commit that referenced this pull request Mar 11, 2022
@MaximilianAlgehed MaximilianAlgehed deleted the PR-symtoken-wellformedness-constraints branch January 4, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants