SCP-3073: emulated ledger #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
force-pushed
the
SCP-3073-emulated-ledger
branch
2 times, most recently
from
600eefe
to
f25ae01
Compare
koslambrou
reviewed
Mar 4, 2022
sjoerdvisscher
force-pushed
the
SCP-3073-emulated-ledger
branch
from
17628af
to
f468d79
Compare
# Conflicts: # plutus-contract/src/Plutus/Contract/Wallet.hs # plutus-contract/src/Wallet/Emulator/Wallet.hs # plutus-contract/test/Spec/Emulator.hs # plutus-contract/test/Spec/golden/traceOutput - pubKeyTransactions.txt # plutus-contract/test/Spec/golden/traceOutput - pubKeyTransactions2.txt # plutus-contract/test/Spec/golden/traceOutput - wait1.txt # plutus-ledger/src/Ledger/Tx/CardanoAPI.hs # plutus-pab/src/Cardano/Node/Types.hs # plutus-pab/src/Cardano/Wallet/Mock/Handlers.hs # plutus-pab/src/Cardano/Wallet/Mock/Server.hs # plutus-pab/src/Plutus/PAB/Run/Cli.hs # plutus-use-cases/test/Spec/crowdfundingEmulatorTestOutput.txt
koslambrou
reviewed
Mar 7, 2022
| let requiredSigners = Map.keys (U.unBalancedTxRequiredSignatories utx) | ||
| theFee <- either (throwError . WAPI.ToCardanoError) pure $ evaluateTransactionFee requiredSigners tx | ||
| tx' <- handleBalanceTx utxo (utx & U.tx . Ledger.fee .~ theFee) | ||
| cTx <- either (throwError . WAPI.ToCardanoError) pure $ fromPlutusTx requiredSigners tx' |
There was a problem hiding this comment.
Why do we need to convert to CardanoApi's tx?
There was a problem hiding this comment.
This is the only place where this is possible since we have the required signers here.
I have added an explanation in the note that explains why we have the Both constructor.
|
@koslambrou Thanks, this was one of those times where I ran out of stamina and forgot about the documentation. |
koslambrou
approved these changes
Mar 9, 2022
|
LGTM! Thanks for the clarification @sjoerdvisscher :) |
bwbush
pushed a commit
that referenced
this pull request
Mar 11, 2022
…o-ledger (#336) * Detect validation errors with cardano-ledger-specs * Calculate (almost) correct fees * Include hashScriptIntegrity in TxBody * Change CardanoTx from Either to These, and adopt it further * Validate validityrange * Make ledger validation errors fail the emulator validation * Ada-only outputs for collateral * Better fee calc, separate out CardanoTx signing * Fix all use-cases tests (except 1 which is now disabled) Co-authored-by: Jann Müller <j-mueller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submit checklist: