Move plutus-example from cardano-node to plutus-apps #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/incorporate-plutus-example
branch
from
8cde37d
to
f9e9bbb
Compare
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
| cabal-version: 3.0 | ||
|
|
||
| name: plutus-example | ||
| version: 1.33.0 |
There was a problem hiding this comment.
What is our versioning policy now that this has moved out of cardano-node? Should it be updated to follow cardano-node's latest version or is this independently versioned now?
newhoggy
reviewed
Feb 22, 2022
|
|
||
|
|
||
| other-modules: | ||
| -- TODO: Re-enable when cardano-node is bumped to the latest master |
There was a problem hiding this comment.
Yeah, plutus-apps is pinned to a cardano-node commit in December which does not have waitUntilEpoch (used in CertifyingAndWithdrawingPlutus)
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
newhoggy
reviewed
Feb 22, 2022
| , plutus-example | ||
| , transformers | ||
|
|
||
| test-suite plutus-example-test |
There was a problem hiding this comment.
Is this currently being run in CI?
There was a problem hiding this comment.
@asutherlandus How do I add this to run in CI?
There was a problem hiding this comment.
It did run in CI: https://hydra.iohk.io/build/12973422
newhoggy
approved these changes
Feb 23, 2022
Jimbo4350
force-pushed
the
jordan/incorporate-plutus-example
branch
2 times, most recently
from
8c792de
to
9e205ed
Compare
catch-21
reviewed
Feb 23, 2022
catch-21
force-pushed
the
jordan/incorporate-plutus-example
branch
from
cf1b5c4
to
86da42c
Compare
Jimbo4350
force-pushed
the
jordan/incorporate-plutus-example
branch
from
86da42c
to
38e3583
Compare
7 tasks
bwbush
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Move plutus-example from cardano-node to plutus-apps * Add dependency on plutus-tx-plugin * Ensure plutus-example Haddocks can be built with plutus-tx-plugin * Convert markdown documentation to rst to fix docs.site build failure * Update plutus-example documentation * set locale encoding to utf8 for plutus-example tests Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net> Co-authored-by: James Browning <james.browning@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.