Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractModel: Improve error messages and statistics reporting #316

Merged
merged 6 commits into from
Feb 21, 2022
Merged

ContractModel: Improve error messages and statistics reporting #316

merged 6 commits into from
Feb 21, 2022

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Feb 16, 2022 •
edited
Loading

The PR also:

  • Cleans up the symbolic tokens interface
  • Refactors the WaitUntil pattern to be built-in to models
  • Adds a standard property for nextReactiveState

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed MaximilianAlgehed changed the title Pr contractmodel convenience updates ContractModel: Improve error messages and statistics reporting Feb 16, 2022
@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft February 16, 2022 14:37
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review February 17, 2022 08:17
@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft February 17, 2022 08:55
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-contractmodel-convenience-updates branch 3 times, most recently from 30771de to fbbe1fd Compare February 17, 2022 13:44
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-contractmodel-convenience-updates branch from fbbe1fd to d67b10c Compare February 19, 2022 11:22
@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher can you have a look at this when you have the free time?

@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review February 21, 2022 09:02
@sjoerdvisscher sjoerdvisscher merged commit 94a22c1 into IntersectMBO:main Feb 21, 2022
@MaximilianAlgehed MaximilianAlgehed deleted the PR-contractmodel-convenience-updates branch February 23, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximilianAlgehed @sjoerdvisscher @rjmh