SCP-3452 chain-index e2e tests #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will open for review after I fix Typescript transpiling |
catch-21
force-pushed
the
chain-index-e2e-tests
branch
2 times, most recently
from
2c537ee
to
9b16666
Compare
koslambrou
reviewed
Feb 16, 2022
plutus-chain-index/e2e-tests/sanity-test/spec/from-hash/stake-validator.spec.ts
Outdated
Show resolved
Hide resolved
catch-21
force-pushed
the
chain-index-e2e-tests
branch
2 times, most recently
from
a5b10e1
to
569a261
Compare
sjoerdvisscher
approved these changes
Feb 16, 2022
koslambrou
reviewed
Feb 16, 2022
| - Update URL in environment file if needed | ||
|
|
||
| ### Run tests: | ||
| - `nvm use` |
There was a problem hiding this comment.
BTW, I think this is optional for users of nix-shell as node is already available (currently v14.17.4).
There was a problem hiding this comment.
Sure. I could remove this cmd and nvmrc file and we always assume run in nix-shell..?
There was a problem hiding this comment.
Yeah exactly! However, you can leave this for those people not using nix-shell, and say that it's unnecessary for those using nix-shell
koslambrou
approved these changes
Feb 20, 2022
catch-21
force-pushed
the
chain-index-e2e-tests
branch
from
569a261
to
b59a676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest API tests that hit each chain-index endpoint. Designed to run on testnet, should be easy enough to extend for mainnet too if desired. Can look at extending this for more complex scenarios such as involving live transactions to check behaviour and performance.
Pre-submit checklist:
Formatting, materialized Nix files, PNG optimization, etc. are updated