Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pab-nami updates #303

Merged
merged 4 commits into from
Feb 9, 2022
Merged

pab-nami updates #303

merged 4 commits into from
Feb 9, 2022

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Feb 7, 2022

Fixes nix-build of the whole project which seemed to fail for couple of reasons:

  • missing export of pab-setup-invoker
  • missing argonaut dependency
  • missing Ord instance for DemoContract

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@sorki sorki mentioned this pull request Feb 9, 2022
Closed
8 tasks
@koslambrou koslambrou self-requested a review February 9, 2022 15:05
@koslambrou
Copy link
Contributor

@sorki Is that completed?

@sorki
Copy link
Contributor Author

sorki commented Feb 9, 2022

Yep. It allowed me to nix-build the whole stack.

@koslambrou
Copy link
Contributor

@sorki Thanks for that :)

@koslambrou koslambrou merged commit 3412d47 into IntersectMBO:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koslambrou koslambrou koslambrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorki @koslambrou