Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-3116: Remove exitWithSuccess in PAB's runWithOpts #299

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

koslambrou
Copy link
Contributor

The exitWithSuccess in Plutus.PAB.Run.runWithOptssimply stops the program, so we can't userunWithOpts` in multiple succession unless we make the calls async. This PR fixes that.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • x ] Useful pull request description
    • Reviewer requested

@koslambrou koslambrou merged commit eda3c99 into main Feb 7, 2022
@koslambrou koslambrou deleted the scp-3116 branch February 7, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants