Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-3435: Refactored error types in Wallet.Types #298

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

koslambrou
Copy link
Contributor

@koslambrou koslambrou commented Feb 4, 2022

Contract error types do not belong in Wallet.Types.

  • Moved error types in Wallet.Types to Plutus.Contract.Error

  • Added a contract error type for chain index errors in Plutus.Contract.Request (ChainIndexContractError)

  • Added a contract error for endpoing decoding and better formatting (EndpointDecodeContractError)

  • Renamed the existing constructors for ContractError

  • Added missing import lists for the modified modules in this commit.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

* Moved error types in `Wallet.Types` to `Plutus.Contract.Error`

* Added a contract error type for chain index errors in `Plutus.Contract.Request (ChainIndexContractError)`

* Added a contract error for endpoing decoding and better formatting (`EndpointDecodeContractError`)

* Renamed the existing constructors for `ContractError`

* Added missing import lists for the modified modules in this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants