Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hackage-nix & cabal index #269

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Conversation

kk-hainq
Copy link
Contributor

  • newer Hackage packages.
  • remove the last manual dep constraint in cabal.project thanks to the new beam-migrate version fixing it.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@kk-hainq kk-hainq marked this pull request as draft January 22, 2022 11:33
@kk-hainq kk-hainq force-pushed the bump-hackage branch 2 times, most recently from 610bdb8 to 57eacf3 Compare January 22, 2022 13:01
@kk-hainq kk-hainq marked this pull request as ready for review January 22, 2022 13:18
@@ -1,65 +1,65 @@
Slot 00000: TxnValidate 98d5fbcefe21113b3f0390c1441e075b8a870cc5a8fa2a56dcde1d8247e41715
Slot 00000: SlotAdd Slot 1
Slot 00001: W1bc5f27: InsertionSuccess: New tip is Tip(slot= Slot 1, blockId= BlockId(-3933910562423127441), blockNo= 0). UTxO state was added to the end.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kk-hainq - do you know why these are changing?

Copy link
Contributor Author

@kk-hainq kk-hainq Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A newer hashable version changed the default Hashable instance of ByteString:
https://github.com/haskell-unordered-containers/hashable/blob/747ff1b58b721fbf355ea1b1a9b66f531bf966e9/CHANGES.md?plain=1#L31-L34

Which affects PlutusTx.Builtins.Internal.BuiltinByteString, then Plutus.V1.Ledger.TxId.TxId, then the blockId in Plutus.Trace.Emulator.System.appendNewTipBlock:
https://github.com/input-output-hk/plutus-apps/blob/8574e9678d7288d3cc3bdafdfa425f5e096b77d4/plutus-contract/src/Plutus/Trace/Emulator/System.hs#L146-L150

Which eventually arrives at this log:
https://github.com/input-output-hk/plutus-apps/blob/8574e9678d7288d3cc3bdafdfa425f5e096b77d4/plutus-chain-index-core/src/Plutus/ChainIndex/Emulator/Handlers.hs#L189

Either way, good catch! The numeric, negative even block ids indeed look weird. I've replaced the ad-hoc hash function with the more "appropriate" blockId function in the third commit: 76358f5.

https://github.com/input-output-hk/plutus-apps/blob/8574e9678d7288d3cc3bdafdfa425f5e096b77d4/plutus-chain-index-core/src/Cardano/Protocol/Socket/Type.hs#L69-L75

kk-hainq and others added 3 commits January 25, 2022 10:19
- newer Hackage packages.
- remove the last manual dep constraint in cabal.project thanks to new
beam-migrate version fixing it.
@silky silky merged commit 30ce3b2 into IntersectMBO:main Jan 25, 2022
@kk-hainq kk-hainq deleted the bump-hackage branch January 25, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants