Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell-nix: also fetch cardano-wallet with more comments #255

Merged
merged 1 commit into from
Jan 17, 2022
Merged

shell-nix: also fetch cardano-wallet with more comments #255

merged 1 commit into from
Jan 17, 2022

Conversation

kk-hainq
Copy link
Contributor

@kk-hainq kk-hainq commented Jan 17, 2022 •
edited
Loading

#213 only guarantees stability and build time for cardano-node executables so this PR does the same for cardano-wallet. It also adds the needed comments.

Also simplifies #214 to make it easier to review (once finalized) and all.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

raduom
raduom approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@raduom raduom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silky silky merged commit def7f30 into IntersectMBO:main Jan 17, 2022
@kk-hainq kk-hainq deleted the refine-nix-shell branch January 17, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raduom raduom raduom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kk-hainq @raduom @silky