Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-3096 - Remove wallet proxy #217

Merged
merged 1 commit into from
Jan 7, 2022
Merged

SCP-3096 - Remove wallet proxy #217

merged 1 commit into from
Jan 7, 2022

Conversation

silky
Copy link
Contributor

@silky silky commented Dec 27, 2021

Don't proxy the wallet backend through our webserver anymore.

Fixes SCP-3096

TODO:

  • When we do a release of plutus-starter, update that endpoint call as well.

The main change here is curl calls like this:

> curl -s -d '' http://localhost:9080/wallet/create

go direct to the wallet server instead:

> curl -s -d '' http://localhost:9081/create

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@silky silky changed the title no more wallet proxy SCP-3096 - Remove wallet proxy Dec 27, 2021
@silky silky marked this pull request as draft December 27, 2021 11:33
@silky silky force-pushed the scp-3096-remove-wallet-proxy branch from 85e1dc6 to e89586b Compare December 29, 2021 12:28
@silky silky marked this pull request as ready for review December 29, 2021 12:31
@silky silky force-pushed the scp-3096-remove-wallet-proxy branch from f17f235 to 01348b1 Compare December 29, 2021 13:59
@silky silky force-pushed the scp-3096-remove-wallet-proxy branch from 01348b1 to 0a38c17 Compare January 7, 2022 10:38
@silky silky merged commit b999f7d into main Jan 7, 2022
@silky silky deleted the scp-3096-remove-wallet-proxy branch January 7, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants